Repository navigation
Revert "fix(a11y): fix Accessible.id crash and compile warning" - #1787
Open
MyLeeJiEun wants to merge 1 commit into
Open
MyLeeJiEun wants to merge 1 commit into
MyLeeJiEun wants to merge 1 commit into
Conversation
This reverts commit 72b624a, except for the m_ActiveId int -> uint change, which is kept to avoid the sign-compare error under -Werror. The Accessible.id workaround is no longer needed: the Qt fix removing REVISION(6, 8) from Accessible.id has already landed in the integration environment, so the static Accessible.id bindings work again. https://github.com/deepin-community/qt6-declarative/pull/37/changes#diff-93467241211d3f9d253fb8ad341738fbda5e5d3ade4721326f2bba82525fbaee
Reviewer's GuideThis PR reverts the Accessible.id crash workaround across dock and notification QML by moving IDs back from Component.onCompleted assignments to declarative bindings, relying on the integrated Qt fix for static Accessible.id support; it also preserves the unsigned m_ActiveId warning fix and restores the prior header copyright year. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价： 语法正确，逻辑清晰 ✅ 通过 潜在问题： 建议： [] 2. 代码质量 ✅评价： 代码结构清晰，注释完整 ✅ 通过 潜在问题： 建议： ['建议将 windowmanager.h 版权年份的修改与 Accessible.id 回退逻辑分开提交，以提高提交的内聚性'] 3. 代码性能 ✅评价： 性能良好，资源使用合理 ✅ 通过 潜在问题： 建议： [] 4. 代码安全 🔒评价： 存在0个安全漏洞 ✅ 通过
安全漏洞详情： 建议： [] 💡 改进建议代码示例当前代码已是正确的声明式写法，无需修复。示例：
// 推荐的声明式写法（本次回退后的结果） ListView {
Accessible.id: "ListView"
id: listView
anchors.fill: parent
}
// 而非之前的命令式 workaround // ListView { // Component.onCompleted: { Accessible.id = "ListView" } // id: listView // anchors.fill: parent // }本报告由 AI 代码审查工具自动生成 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 72b624a, except for the m_ActiveId int -> uint change, which is kept to avoid the sign-compare error under -Werror.
The Accessible.id workaround is no longer needed: the Qt fix removing REVISION(6, 8) from Accessible.id has already landed in the integration environment, so the static Accessible.id bindings work again. https://github.com/deepin-community/qt6-declarative/pull/37/changes#diff-93467241211d3f9d253fb8ad341738fbda5e5d3ade4721326f2bba82525fbaee
Summary by Sourcery
Restore static accessibility ID assignments throughout the dock and notification interfaces while preserving the compiler-warning fix.
Bug Fixes:
Enhancements:
Chores: