Repository navigation
fix(shellgen): avoid ETXTBSY when forking while writing scripts - #3037
Open
mikeland73 wants to merge 1 commit into
Open
mikeland73 wants to merge 1 commit into
mikeland73 wants to merge 1 commit into
Conversation
A goroutine that forks while another has a script temp file open for writing leaves the writable fd in the child until it execs. On Linux, exec'ing the script in that window fails with "Text file busy", which made TestConcurrentRunScriptFiles flaky on ubuntu CI. Hold syscall.ForkLock for reading while the temp file is open (golang/go#22315). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestConcurrentRunScriptFiles(added in #3032) flaked on ubuntu CI with.cmd.sh: Text file busy(run). When one goroutine forks while another still has a script temp file open for writing, the child keeps that writable fd until it execs, and on Linux exec'ing the script in that window fails with ETXTBSY (golang/go#22315).writeScriptFileAtomicnow writes the temp file in a newwriteTempFilehelper that holdssyscall.ForkLockfor reading while the file is open, so no fork can inherit the writable fd.How was it tested?
On macOS,
go test -race -count=20 -run TestConcurrentRunScriptFiles ./internal/devboxandgo test ./internal/shellgenpass, anddevbox run lintis clean. ETXTBSY doesn't happen on macOS, so the ubuntu CI job is the real check for this change.Community Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.
🤖 Generated with Claude Code