From 6e005ecf65314fa5081c1ea2a873d85e6828d6fe Mon Sep 17 00:00:00 2001 From: Lahiru Maramba Date: Thu, 24 Sep 2026 18:12:16 -0400 Subject: [PATCH 1/3] fix: skip integration tests during release publish --- .github/scripts/publish_artifacts.sh | 1 + pom.xml | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/.github/scripts/publish_artifacts.sh b/.github/scripts/publish_artifacts.sh index 5da0f32a4..3f4433b5a 100755 --- a/.github/scripts/publish_artifacts.sh +++ b/.github/scripts/publish_artifacts.sh @@ -30,6 +30,7 @@ gpg --import --no-tty --batch --yes firebase.asc mvn -B clean deploy \ -Dcheckstyle.skip \ -DskipTests \ + -DskipITs \ -Prelease \ --settings .github/resources/settings.xml diff --git a/pom.xml b/pom.xml index 508605d51..2029e3a23 100644 --- a/pom.xml +++ b/pom.xml @@ -59,6 +59,7 @@ UTF-8 UTF-8 ${skipTests} + ${skipTests} 4.2.18.Final @@ -146,6 +147,9 @@ release + + true + @@ -331,6 +335,9 @@ maven-failsafe-plugin 3.6.0 + + ${skipITs} + From 7c4155c122afd520a81a171db3d0f21aef3da7fa Mon Sep 17 00:00:00 2001 From: Lahiru Maramba Date: Thu, 24 Sep 2026 18:16:40 -0400 Subject: [PATCH 2/3] chore: publish artifacts to Maven Central before creating release tag --- .github/workflows/release.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 4830029e8..7a64bd46a 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -106,6 +106,15 @@ jobs: id: preflight run: ./.github/scripts/publish_preflight_check.sh + - name: Publish to Maven Central + run: ./.github/scripts/publish_artifacts.sh + env: + GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }} + GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }} + GPG_KEY_ID: ${{ secrets.GPG_KEY_ID }} + CENTRAL_USERNAME: ${{ secrets.CENTRAL_USERNAME }} + CENTRAL_TOKEN: ${{ secrets.CENTRAL_TOKEN }} + # See: https://cli.github.com/manual/gh_release_create - name: Create release tag env: @@ -116,12 +125,3 @@ jobs: gh release create "$RELEASE_VER" \ --title "Firebase Admin Java SDK $RELEASE_VER" \ --notes "$RELEASE_BODY" - - - name: Publish to Maven Central - run: ./.github/scripts/publish_artifacts.sh - env: - GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }} - GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }} - GPG_KEY_ID: ${{ secrets.GPG_KEY_ID }} - CENTRAL_USERNAME: ${{ secrets.CENTRAL_USERNAME }} - CENTRAL_TOKEN: ${{ secrets.CENTRAL_TOKEN }} From fd7b24c782e9e4782ab42c24c1210ea1deb9c762 Mon Sep 17 00:00:00 2001 From: Lahiru Maramba Date: Thu, 24 Sep 2026 18:33:09 -0400 Subject: [PATCH 3/3] chore: address review feedback on release test skipping --- .github/scripts/publish_artifacts.sh | 1 - pom.xml | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/scripts/publish_artifacts.sh b/.github/scripts/publish_artifacts.sh index 3f4433b5a..5da0f32a4 100755 --- a/.github/scripts/publish_artifacts.sh +++ b/.github/scripts/publish_artifacts.sh @@ -30,7 +30,6 @@ gpg --import --no-tty --batch --yes firebase.asc mvn -B clean deploy \ -Dcheckstyle.skip \ -DskipTests \ - -DskipITs \ -Prelease \ --settings .github/resources/settings.xml diff --git a/pom.xml b/pom.xml index 2029e3a23..66da562a1 100644 --- a/pom.xml +++ b/pom.xml @@ -58,6 +58,7 @@ UTF-8 UTF-8 + false ${skipTests} ${skipTests} 4.2.18.Final @@ -335,9 +336,6 @@ maven-failsafe-plugin 3.6.0 - - ${skipITs} -