From dc47de849a807daf28bdbfc6c8bade80ff93006f Mon Sep 17 00:00:00 2001 From: dsward2 Date: Tue, 22 Sep 2026 23:39:06 -0500 Subject: [PATCH] CI: drop obsolete Homebrew lame / pkg-config steps libmp3lame has been vendored as Frameworks/Mp3Lame.xcframework (a SwiftPM binary target) since de1e033, so the workflow no longer needs Homebrew's lame. Those leftover steps broke every run once Homebrew's lame 4.0 bottle stopped shipping mp3lame.pc (pkg-config --libs mp3lame: not found). Also correct the README's Building section, which still said lame came from the dropped PipelineHelpers dependency. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/build.yml | 6 ------ README.md | 7 +++---- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 764a9de..f1a189f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -22,12 +22,6 @@ jobs: - name: Show Swift version run: swift --version - - name: Install libmp3lame - run: brew install lame pkg-config - - - name: Verify pkg-config sees mp3lame - run: pkg-config --libs mp3lame - - name: Build run: swift build -c ${{ matrix.config }} diff --git a/README.md b/README.md index 7f8346b..492e57b 100644 --- a/README.md +++ b/README.md @@ -376,10 +376,9 @@ and the helper will dyld-resolve `LiveAudioServerCore` out of - macOS 14 (Sonoma) or later - Xcode 15.4+ / Swift 5.10+ (uses the [Swift Testing](https://github.com/apple/swift-testing) framework for unit tests) -No external package manager (Homebrew/MacPorts) required — MP3/AAC encoding -comes from the [PipelineHelpers](https://github.com/dsward2/PipelineHelpers) -package's `AudioEncoders` library, which SwiftPM fetches automatically and -which vendors `libmp3lame` as a prebuilt XCFramework itself. +No external package manager (Homebrew/MacPorts) required — `libmp3lame` is +vendored as a prebuilt static XCFramework (`Frameworks/Mp3Lame.xcframework`) +and AAC uses the system AudioToolbox framework. ```bash cd LiveAudioServer