Repository navigation
Conversation
jefft72
requested review from
Issacboy123 and
Pepps233
and removed request for
Issacboy123
August 16, 2026 00:11
Issacboy123
force-pushed
the
stack/native-plan-13-ui-handoff-tests
branch
from
August 16, 2026 03:14
7b866c2 to
43e19c0
Compare
Exercise serialized editor ownership, delayed login completion, overlay focus, rebind-safe handoffs, and bounded profile rendering.
Verify cancellation restoration, duplicate profile mapping, teardown settlement, prompt locking, hook UI, and compact decision actions.
Pepps233
force-pushed
the
stack/native-plan-13-ui-handoff-tests
branch
from
August 16, 2026 04:19
43e19c0 to
ce1f61a
Compare
Contributor
Author
|
Closing to rebuild on a clean base. This stack does not build. Two separate defects are present, and the first masks the second:
Replacement stacks:
The branch behind this PR is retained unchanged as a backup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds virtual-terminal regression coverage for native-plan editor ownership and ambiguous implementation-profile handoffs.
The suite drives real TUI components through focus changes, overlays, delayed asynchronous completion, session rebind teardown, selector input, and narrow viewports to verify the behavior users actually see during plan acceptance.
Reasoning
Plan decisions and implementation handoffs temporarily replace the normal editor while authentication dialogs, extension selectors, overlays, runtime routing, and lifecycle rebinds can all compete for the same focus.
Token-based ownership is only safe if stale asynchronous completions cannot restore old UI, every abort path settles once, and accepted-plan input remains blocked until the continuation has synchronously acquired prompt ownership.
The profile chooser also exposes trusted descriptions, safeguards, and tool policies that may contain terminal control sequences or exceed the available viewport.
End-to-end component coverage is needed to prove that this information stays legible and safe while the selected option still maps to the correct stable profile identity.
Changes
before_agent_startUI can mount after synchronous prompt ownership and remains focused after the continuation starts.Testing
npm run checkpassed against the final rebased 14-PR stack.