Repository navigation
Conversation
jefft72
requested review from
Issacboy123 and
Pepps233
and removed request for
Issacboy123
August 16, 2026 00:11
Issacboy123
force-pushed
the
stack/native-plan-12-resolution-lifecycle-tests
branch
from
August 16, 2026 03:14
5f22f49 to
222e375
Compare
Verify durable acceptance, retries, selector suppression, cancellation, streaming admission, and transcript plan rendering.
Exercise startup serialization, restored continuations, session rebinds, navigation notices, and settled-event behavior.
Pepps233
force-pushed
the
stack/native-plan-12-resolution-lifecycle-tests
branch
from
August 16, 2026 04:19
222e375 to
aae4a3f
Compare
Contributor
Author
|
Closing to rebuild on a clean base. This stack does not build. Two separate defects are present, and the first masks the second:
Replacement stacks:
The branch behind this PR is retained unchanged as a backup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused regression coverage for the complete native-plan resolution lifecycle without changing production behavior in this stack entry.
The new suites exercise durable implement, keep-planning, discard, retry, cancellation, admission, startup, rebind, navigation, and transcript-restoration paths against the interactive-mode contracts introduced earlier in the stack.
Reasoning
Plan resolution crosses persisted session state, runtime routing, prompt preflight, editor admission, and transcript rendering.
A race or stale reference at any one of those boundaries can lose an accepted continuation, submit it twice, resolve the wrong session after a rebind, hide a pending plan, or send startup input before the user has decided what to do.
The tests lock down both event ordering and the user-visible recovery messages around those boundaries.
They also distinguish expected cancellation from implementation failure and verify that durable state remains the source of truth when the interactive session is restored, compacted, navigated, or rebound.
Changes
/planretry while producing the correct error or non-error status.agent_settledevent does not independently reopen the plan selector.plan_submittedrendering, persisted plan-entry replay, and recovery of a pending plan omitted from compaction-filtered transcript entries without duplicating an artifact already present.Testing
npm run checkpassed against the final rebased 14-PR stack.