(.*?)<\/div>/s,
+ );
+
+ assert.equal(block?.[1].replace(/<[^>]+>/g, ''), 'Image');
+});
+
+test('includes quotes in the unfiltered empty inbox message', async () => {
assert.match(await renderInbox([]), /replies, quotes, mentions/);
});
-void test('renders a follow-back control outside the follower profile link', async () => {
+test('renders a follow-back control outside the follower profile link', async () => {
const follow: NotificationGroup = {
...quote,
type: 'followed',
@@ -171,7 +191,7 @@ void test('renders a follow-back control outside the follower profile link', asy
);
});
-void test('leaves follow-back out of a group of followers until it is expanded', async () => {
+test('leaves follow-back out of a group of followers until it is expanded', async () => {
const html = await renderInbox([
{
...quote,
@@ -189,7 +209,7 @@ void test('leaves follow-back out of a group of followers until it is expanded',
assert.doesNotMatch(html, /aria-label="(Follow|Unfollow) @/);
});
-void test('renders notification code without altering emoji shortcodes or nesting interactive controls', async () => {
+test('renders notification code without altering emoji shortcodes or nesting interactive controls', async () => {
const html = await renderInbox([
{
...quote,
@@ -205,7 +225,7 @@ void test('renders notification code without altering emoji shortcodes or nestin
assert.doesNotMatch(html, /Copy code/);
});
-void test('renders highlighted notification blocks without a nested copy button', async () => {
+test('renders highlighted notification blocks without a nested copy button', async () => {
const html = await renderInbox([
{
...quote,
@@ -230,14 +250,13 @@ void test('renders highlighted notification blocks without a nested copy button'
assert.doesNotMatch(html, /Copy code/);
});
-
-void test('renders all notification categories as enabled toggle buttons by default', async () => {
+test('renders all notification categories as enabled toggle buttons by default', async () => {
const body = await renderInbox([]);
assert.equal((body.match(/aria-pressed="true"/g) ?? []).length, 6);
assert.doesNotMatch(body, /aria-current="page"|role="tab"/);
});
-void test('renders independent category selections and the all-off empty state', async () => {
+test('renders independent category selections and the all-off empty state', async () => {
const selected = await renderInbox([], 'replies,mentions');
assert.equal((selected.match(/aria-pressed="true"/g) ?? []).length, 2);
assert.equal((selected.match(/aria-pressed="false"/g) ?? []).length, 4);
diff --git a/tests/Unit/NotificationIndex.test.tsx b/tests/Unit/NotificationIndex.test.tsx
index aef013c81..eb9459b86 100644
--- a/tests/Unit/NotificationIndex.test.tsx
+++ b/tests/Unit/NotificationIndex.test.tsx
@@ -1,12 +1,16 @@
///
import assert from 'node:assert/strict';
-import { test } from 'node:test';
import { createInertiaApp } from '@inertiajs/react';
import { renderToString } from 'react-dom/server';
+import { test } from 'vite-plus/test';
import { TooltipProvider } from '../../resources/js/components/ui/tooltip';
import Index from '../../resources/js/pages/notification/index';
-import type { Commit, NotificationGroup, User } from '../../resources/js/types';
+import type {
+ NotificationCommit,
+ NotificationGroup,
+ User,
+} from '../../resources/js/types';
const actor = {
id: 'actor',
@@ -39,7 +43,8 @@ const notification = {
html: '
return round($score, 6);',
},
],
- } as Omit
,
+ images_count: 0,
+ } as NotificationCommit,
} as NotificationGroup;
async function render(notifications: NotificationGroup[]): Promise {
@@ -85,7 +90,7 @@ async function render(notifications: NotificationGroup[]): Promise {
return result.body.slice(result.body.indexOf(' {
+test('renders a code block highlighted in a notification', async () => {
const body = await render([notification]);
assert.match(body, /]*>return<\/span>/);
@@ -95,8 +100,34 @@ void test('renders a code block highlighted in a notification', async () => {
assert.match(body, /]*tabindex="-1"/i);
});
+for (const [imagesCount, label] of [
+ [1, 'Image'],
+ [3, '3 images'],
+] as const) {
+ test(`says "${label}" for a starred commit of images alone instead of an empty excerpt`, async () => {
+ const starred = {
+ ...notification,
+ type: 'starred',
+ commit_id: 'images',
+ subject_id: 'images',
+ commit: {
+ id: 'images',
+ body: '',
+ body_segments: [],
+ images_count: imagesCount,
+ } as NotificationCommit,
+ } as NotificationGroup;
+ const body = await render([starred]);
+ const block = body.match(
+ /(.*?)<\/div>/s,
+ );
+
+ assert.equal(block?.[1].replace(/<[^>]+>/g, ''), label);
+ });
+}
+
for (const isFollowing of [false, true]) {
- void test(`keeps ${isFollowing ? 'unfollow' : 'follow-back'} separate from highlighted notification links`, async () => {
+ test(`keeps ${isFollowing ? 'unfollow' : 'follow-back'} separate from highlighted notification links`, async () => {
const followed = {
...notification,
id: 'follow-notification',
diff --git a/tests/draft-images.config.ts b/tests/draft-images.config.ts
index 417007754..4aa92c656 100644
--- a/tests/draft-images.config.ts
+++ b/tests/draft-images.config.ts
@@ -23,6 +23,8 @@ export default defineConfig({
'tests/Unit/SearchDialogComposition.test.tsx',
'tests/Unit/ReportResolution.test.tsx',
'tests/Unit/LinkifiedText.test.tsx',
+ 'tests/Unit/NotificationIndex.test.tsx',
+ 'tests/Unit/NotificationInbox.test.tsx',
],
},
});