Skip to content

Commit c19468a

Browse files
committed
docs(bot): clarify lesson provenance and formatting
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
1 parent ee9d7e1 commit c19468a

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

‎.claude/knowledge/learning-log.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ Preserves the entries from PR #1018 at
55
New daily entries belong in `journal/`; bots receive distilled rules from
66
`lessons.md`. This archive is never updated or injected into bot prompts.
77

8+
Lesson counts measure archived occurrences, not distinct PRs. A
9+
`log:YYYY-MM-DD` source points to that dated section below, including its author-run IDs.
10+
811
## Entries
912

1013
### 2026-08-13: learnings since 2026-08-04T18:01:30Z

‎.claude/knowledge/lessons.md‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
<!-- distilled-through: none -->
44

55
## Backend contracts and configuration
6-
7-
- L-0001 (1×, #1018): When changing cursor.description type_code strings, update every downstream conversion branch that matches them.
6+
- L-0001 (1×, log:2026-08-13): When changing cursor.description type_code strings, update every downstream conversion branch that matches them.
87
- L-0002 (1×, #560): Recover Spark SQL types sharing a Thrift TTypeId from Arrow field Spark:DataType:SqlName metadata.
98
- L-0003 (4×, #910 #921 #919): New resolver branches must preserve mutual-exclusion checks and forward shared options on every applicable path; directly test forwarding even when omission has a safe default.
109
- L-0004 (2×, #916 #922): Use Thrift as the reference when checking kernel value semantics; deprecated SEA behavior can differ.
@@ -26,34 +25,34 @@
2625
- L-0020 (1×, #974): Before replacing permissive wire parsing with typed parsing, verify real server representations and test case, quoting and numeric/bool variants.
2726
- L-0021 (1×, #985): SQL LIKE escape handling depends on preceding backslash-run parity; a one-character negative lookbehind cannot establish JDBC equivalence.
2827
- L-0022 (1×, #1026): Reject bool explicitly when validating integer options before native conversion, so True/False cannot silently become 1/0.
29-
## Results and lifecycle
3028

29+
## Results and lifecycle
3130
- L-0023 (2×, #1019): Verify server metadata and forwarded configuration behavior with live tests and an opposite-setting positive control; fabricated metadata or forwarding-only unit tests cannot establish server behavior.
3231
- L-0024 (2×, #923): Keep the original async owning handle for telemetry-producing polls/results. Reserve retained handles against concurrent use and use attach-by-id for resume/refetch or concurrent fallback.
3332
- L-0025 (2×, #907): Lazy imports must preserve every formerly exported name and patch seam. Import-isolation subprocess tests need distinct success/error sentinels so import crashes cannot satisfy assertions.
3433
- L-0026 (1×, #975): Dependency upgrades may tighten size/depth defaults; explicitly set relied-on limits and test them.
3534
- L-0027 (1×, #990): Pair result columns with Arrow fields by position to preserve duplicate aliases; use names only as a documented malformed/short-schema fallback.
3635
- L-0028 (2×, #995): Use plain concat_tables when chunk schemas match, preserving valid duplicate column names. Enable promote/promote_options only for genuinely differing schemas.
37-
- L-0029 (1×, #1018): Preserve NaN, NULL and positive/negative infinity distinctly through pandas conversion, comparing nullable-dtype behavior with the as_py path.
36+
- L-0029 (1×, log:2026-10-30): Preserve NaN, NULL and positive/negative infinity distinctly through pandas conversion, comparing nullable-dtype behavior with the as_py path.
3837
- L-0030 (1×, #1013): When broadening rendering input types, explicitly test formerly rejected strings, bytes, sets and empty containers so loud failures cannot become silently wrong values.
3938
- L-0031 (1×, #1017): Enforce runtime Optional-state invariants with descriptive driver errors; Python -O removes assert statements.
4039
- L-0032 (1×, #1022): KERNEL_REV changes CI source only. Shipping a kernel fix requires a released wheel and matching packaging floor/lock update, plus an in-repo E2E regression.
4140
- L-0033 (1×, #1020): Prove optional C acceleration actually executes and skip when unavailable. Choose input/output protocols separately and verify encoded bytes and nesting limits against the fallback.
4241
- L-0034 (1×, #1016): Carry sync result metadata into async get_execution_result. Read numModifiedRows from the existing terminal FINISHED_STATE status response via the shared helper, avoiding an extra RPC.
43-
## Logging and concurrency
4442

43+
## Logging and concurrency
4544
- L-0035 (2×, #924): pyo3-log caches effective logger levels. Reset its cache after relevant level changes/session setup and isolate cached state in tests.
4645
- L-0036 (3×, #947): Logging filters that rewrite record.args must separately handle None, positional tuples and mapping dictionaries, with coverage for all three.
4746
- L-0037 (1×, #974): Keep shared locks out of blocking network I/O; coordinate in-flight work without serializing unrelated callers on a slow fetch.
4847
- L-0038 (1×, #974): Do not retain singleton executors/clients that other paths can destroy and replace; resolve them at use time or handle shutdown races.
4948
- L-0039 (1×, #1020): Log large payloads with lazy percent-format arguments; eager f-strings/format calls consume CPU and memory even when the logger is disabled.
5049
- L-0040 (1×, #1055): urllib3 pool mocks must route both _get_conn and _put_conn by test thread. Mock close returning None and prove isolation with concurrent users of one shared pool.
5150
- L-0041 (1×, #1024): Reset process-global caches with autouse fixtures in tests that exercise them; each test must start cold.
52-
## Verification and bot workflow
5351

52+
## Verification and bot workflow
5453
- L-0042 (1×, #905 #906): Bot MODEL_ENDPOINT must name the concrete model serving-endpoints/model/invocations URL; the anthropic/invocations form produces an invalid translated CLI path.
5554
- L-0043 (3×, #930): Keep planning read-only, structured output concise, and PR summaries aligned with the complete final diff.
56-
- L-0044 (1×, #1018): Performance tests should count calls to the real expensive operation through a spy and assert deterministic bounds instead of live wall-clock timings.
55+
- L-0044 (1×, log:2026-10-30): Performance tests should count calls to the real expensive operation through a spy and assert deterministic bounds instead of live wall-clock timings.
5756
- L-0045 (1×, #1004): Recheck capability claims after tool upgrades; replacing version numbers inside old support statements does not validate them.
5857
- L-0046 (1×, #1013): Confirm targeted regression tests fail when their guarded check is removed; inject inputs where earlier sanitization cannot neutralize the case.
5958
- L-0047 (1×, #1045): Secret-bearing CI steps must run Python isolated or from a neutral directory, preventing checkout modules from shadowing trusted imports.

0 commit comments

Comments
 (0)