From 5e0c1182164c515146af5d2524369f856cfbc391 Mon Sep 17 00:00:00 2001 From: Andreas Arvidsson Date: Sun, 15 Nov 2026 08:21:10 +0100 Subject: [PATCH 1/2] Require a minimum vscode version of 1.107.0 --- packages/app-vscode/package.json | 4 +-- .../src/ide/vscode/VscodeCapabilities.ts | 5 +--- packages/lib-neovim-common/package.json | 2 +- packages/lib-vscode-common/package.json | 2 +- .../src/launchVscodeAndRunTests.ts | 2 +- packages/test-vscode-e2e/package.json | 4 +-- .../src/suite/shouldSkipTest.ts | 16 +---------- pnpm-lock.yaml | 28 ++++++++----------- 8 files changed, 19 insertions(+), 44 deletions(-) diff --git a/packages/app-vscode/package.json b/packages/app-vscode/package.json index e9b2a547b9a..9deb809d085 100644 --- a/packages/app-vscode/package.json +++ b/packages/app-vscode/package.json @@ -18,7 +18,7 @@ "type": "module", "main": "./extension.cjs", "engines": { - "vscode": "^1.98.0" + "vscode": "^1.107.0" }, "extensionKind": [ "ui", @@ -1289,7 +1289,7 @@ "@types/node": "^24.19.2", "@types/semver": "^7.8.0", "@types/sinon": "^22.0.0", - "@types/vscode": "1.98.0", + "@types/vscode": "1.107.0", "esbuild": "^0.28.2", "fast-xml-parser": "^5.11.2", "fs-extra": "^11.4.1", diff --git a/packages/app-vscode/src/ide/vscode/VscodeCapabilities.ts b/packages/app-vscode/src/ide/vscode/VscodeCapabilities.ts index 64f20560420..c01cb8edf18 100644 --- a/packages/app-vscode/src/ide/vscode/VscodeCapabilities.ts +++ b/packages/app-vscode/src/ide/vscode/VscodeCapabilities.ts @@ -1,5 +1,3 @@ -import semver from "semver"; -import vscode from "vscode"; import type { Capabilities, CommandCapabilityMap, @@ -8,8 +6,7 @@ import { nodeGetRunMode } from "@cursorless/lib-node-common"; // FIXME: In newer versions of vscode the `editor.action.clipboardCopyAction` // command appears to be disabled / sandboxed in test mode. -const supportsCopy = - nodeGetRunMode() !== "test" || semver.lt(vscode.version, "1.98.0"); +const supportsCopy = nodeGetRunMode() !== "test"; const COMMAND_CAPABILITIES: CommandCapabilityMap = { clipboardCopy: supportsCopy ? { acceptsLocation: false } : undefined, diff --git a/packages/lib-neovim-common/package.json b/packages/lib-neovim-common/package.json index 31fe82898a1..d99f8b43b06 100644 --- a/packages/lib-neovim-common/package.json +++ b/packages/lib-neovim-common/package.json @@ -22,6 +22,6 @@ }, "devDependencies": { "@types/lodash-es": "^4.17.12", - "@types/vscode": "1.98.0" + "@types/vscode": "1.107.0" } } diff --git a/packages/lib-vscode-common/package.json b/packages/lib-vscode-common/package.json index 53dcbb26479..472a2e6f4c6 100644 --- a/packages/lib-vscode-common/package.json +++ b/packages/lib-vscode-common/package.json @@ -15,6 +15,6 @@ "@cursorless/lib-common": "workspace:*" }, "devDependencies": { - "@types/vscode": "1.98.0" + "@types/vscode": "1.107.0" } } diff --git a/packages/test-runner/src/launchVscodeAndRunTests.ts b/packages/test-runner/src/launchVscodeAndRunTests.ts index a312ea240ed..fb440123eb6 100644 --- a/packages/test-runner/src/launchVscodeAndRunTests.ts +++ b/packages/test-runner/src/launchVscodeAndRunTests.ts @@ -36,7 +36,7 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) { // we don't have to update the branch protection rules every time we bump // the legacy VSCode version. - const vscodeVersion = useLegacyVscode ? "1.98.0" : "stable"; + const vscodeVersion = useLegacyVscode ? "1.107.0" : "stable"; const vscodeExecutablePath = await downloadAndUnzipVSCode(vscodeVersion); const [cli, ...args] = resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath); diff --git a/packages/test-vscode-e2e/package.json b/packages/test-vscode-e2e/package.json index a93042de275..1db854471ad 100644 --- a/packages/test-vscode-e2e/package.json +++ b/packages/test-vscode-e2e/package.json @@ -19,10 +19,8 @@ "devDependencies": { "@types/lodash-es": "^4.17.12", "@types/mocha": "^10.0.10", - "@types/semver": "^7.8.0", "@types/sinon": "^22.0.0", - "@types/vscode": "1.98.0", - "semver": "^7.8.5", + "@types/vscode": "1.107.0", "sinon": "^22.1.0" } } diff --git a/packages/test-vscode-e2e/src/suite/shouldSkipTest.ts b/packages/test-vscode-e2e/src/suite/shouldSkipTest.ts index c14dc2301ee..bf0e22d76d4 100644 --- a/packages/test-vscode-e2e/src/suite/shouldSkipTest.ts +++ b/packages/test-vscode-e2e/src/suite/shouldSkipTest.ts @@ -1,13 +1,3 @@ -import semver from "semver"; -import vscode from "vscode"; - -/** - * FIXME: On newer vscode versions some Tree sitter parser throws memory errors - * https://github.com/cursorless-dev/cursorless/issues/2879 - */ -const isVersionProblematic = - semver.lt(vscode.version, "1.107.0") && semver.gte(vscode.version, "1.98.0"); - export function shouldSkipRecordedTest(name: string): boolean { switch (name) { case "recorded/docs/actions/randomizeTargets": @@ -15,9 +5,5 @@ export function shouldSkipRecordedTest(name: string): boolean { // No default } - return isVersionProblematic && name.startsWith("recorded/languages/latex/"); -} - -export function shouldSkipScopeTest(languageId: string): boolean { - return isVersionProblematic && languageId === "latex"; + return false; } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 135a0a55583..2467aad7634 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -158,8 +158,8 @@ importers: specifier: ^22.0.0 version: 22.0.0 '@types/vscode': - specifier: 1.98.0 - version: 1.98.0 + specifier: 1.107.0 + version: 1.107.0 esbuild: specifier: ^0.28.2 version: 0.28.2 @@ -486,8 +486,8 @@ importers: specifier: ^4.17.12 version: 4.17.12 '@types/vscode': - specifier: 1.98.0 - version: 1.98.0 + specifier: 1.107.0 + version: 1.107.0 packages/lib-neovim-registry: {} @@ -592,8 +592,8 @@ importers: version: link:../lib-common devDependencies: '@types/vscode': - specifier: 1.98.0 - version: 1.98.0 + specifier: 1.107.0 + version: 1.107.0 packages/lib-vscode-tutorial-webview: dependencies: @@ -740,18 +740,12 @@ importers: '@types/mocha': specifier: ^10.0.10 version: 10.0.10 - '@types/semver': - specifier: ^7.8.0 - version: 7.8.0 '@types/sinon': specifier: ^22.0.0 version: 22.0.0 '@types/vscode': - specifier: 1.98.0 - version: 1.98.0 - semver: - specifier: ^7.8.5 - version: 7.8.5 + specifier: 1.107.0 + version: 1.107.0 sinon: specifier: ^22.1.0 version: 22.1.0 @@ -4980,8 +4974,8 @@ packages: '@types/vscode-webview@1.57.5': resolution: {integrity: sha512-iBAUYNYkz+uk1kdsq05fEcoh8gJmwT3lqqFPN7MGyjQ3HVloViMdo7ZJ8DFIP8WOK74PjOEilosqAyxV2iUFUw==} - '@types/vscode@1.98.0': - resolution: {integrity: sha512-+KuiWhpbKBaG2egF+51KjbGWatTH5BbmWQjSLMDCssb4xF8FJnW4nGH4nuAdOOfMbpD0QlHtI+C3tPq+DoKElg==} + '@types/vscode@1.107.0': + resolution: {integrity: sha512-XS8YE1jlyTIowP64+HoN30OlC1H9xqSlq1eoLZUgFEC8oUTO6euYZxti1xRiLSfZocs4qytTzR6xCBYtioQTCg==} '@types/ws@8.18.2': resolution: {integrity: sha512-67MQl+fpWKVTT1NYdnmo3U4sc/xPo/zQBncVnI74qmQa0z/b+1g6iYqNmGCPbxO+zz2aklb08a0oHfegiVd0/w==} @@ -16423,7 +16417,7 @@ snapshots: '@types/vscode-webview@1.57.5': {} - '@types/vscode@1.98.0': {} + '@types/vscode@1.107.0': {} '@types/ws@8.18.2': dependencies: From 449c2bb60b931c501fbd7dd1686d322d1f02034d Mon Sep 17 00:00:00 2001 From: Andreas Arvidsson Date: Sun, 15 Nov 2026 08:22:38 +0100 Subject: [PATCH 2/2] Update lock file --- pnpm-lock.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 2467aad7634..e1b9e7f50fb 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -16221,7 +16221,7 @@ snapshots: '@types/cross-spawn@6.0.6': dependencies: - '@types/node': 26.6.5 + '@types/node': 24.19.2 '@types/debug@4.1.13': dependencies: @@ -16330,6 +16330,7 @@ snapshots: '@types/node@26.6.5': dependencies: undici-types: 8.9.0 + optional: true '@types/normalize-package-data@2.4.4': {}