From 89d019a181cce9b71c0b2af4789c618c1726bda0 Mon Sep 17 00:00:00 2001 From: Ricardo Date: Sat, 3 Oct 2026 21:05:32 +0200 Subject: [PATCH 1/2] adds @semx to CODEOWNERS --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 127f58c6..3a5333e1 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,5 +1,5 @@ -* @bb-ricardo +* @semx @bb-ricardo /sources/hetzner/ @SerhiiZahuba From 189aad5128c1e56f02cd2d486bfb6bf03d941c21 Mon Sep 17 00:00:00 2001 From: Thomas Foks Date: Wed, 7 Oct 2026 13:16:41 +0200 Subject: [PATCH 2/2] fix(VMware): query network hints of all host NICs QueryNetworkHint() expects an optional list of device names. Passing "" makes vCenter look up a NIC with an empty name and raise vim.fault.NotFound, which was silently ignored. As a result no CDP/LLDP data was ever read: the neighbor info was missing from the pNIC descriptions and sync_host_cables never created any cables. Call QueryNetworkHint() without arguments and log a failing query instead of discarding it. Co-Authored-By: Claude Opus 5.5 --- module/sources/vmware/connection.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/module/sources/vmware/connection.py b/module/sources/vmware/connection.py index 27ea23c3..60cf56de 100644 --- a/module/sources/vmware/connection.py +++ b/module/sources/vmware/connection.py @@ -2433,10 +2433,10 @@ def add_host(self, obj): pnic_hints = dict() # noinspection PyBroadException try: - for hint in obj.configManager.networkSystem.QueryNetworkHint(""): + for hint in obj.configManager.networkSystem.QueryNetworkHint(): pnic_hints[hint.device] = hint - except Exception: - pass + except Exception as e: + log.debug(f"Unable to query network hints (CDP/LLDP) of host '{name}': {e}") pnic_list = grab(obj, "config.network.pnic", fallback=list()) if self.settings.skip_host_nics is True: