From 9a5847afba26128a704969c709a4548be805018e Mon Sep 17 00:00:00 2001 From: Lukasz Lenart Date: Thu, 17 Sep 2026 13:21:49 +0200 Subject: [PATCH 1/2] docs(skills): send the [TEST] mail from the @apache.org identity The Gmail draft tool has no sender field, so the 7.4.0 and 6.12.0 test-build drafts were created under the personal default address and had to be switched by hand. Record the identity in the skill and add the hand-over line to the checklist, matching the rule creating-release-vote-mail already carries for the [VOTE]. Co-Authored-By: Claude Opus 5 (1M context) --- .claude/skills/creating-version-notes/SKILL.md | 6 ++++++ .../skills/creating-version-notes/version-notes-template.md | 1 + 2 files changed, 7 insertions(+) diff --git a/.claude/skills/creating-version-notes/SKILL.md b/.claude/skills/creating-version-notes/SKILL.md index fd8a0fd3ca..26fba47380 100644 --- a/.claude/skills/creating-version-notes/SKILL.md +++ b/.claude/skills/creating-version-notes/SKILL.md @@ -272,6 +272,12 @@ Kind regards Do not take the recipients from a previous announcement: 6.11.0 went to `dev@` alone and 7.3.0 to `user@` alone, and both were mistakes. Address every announcement to the two lists above. +**It is sent from `lukaszlenart@apache.org`, and the draft cannot say so.** The Gmail draft tool has no +sender field, so every draft it creates carries the account's personal default address. When handing +the draft over, say in the same sentence that the From must be switched to the `@apache.org` identity +before sending — a test build announced from a personal address reads as an outsider's mail in the +list archive, and `creating-release-vote-mail` needs the same switch for the `[VOTE]`. + Keep the security posture of the pages: the mail links the release notes, it does not summarise what is in them, so no severity, CVE or S2-XXX reaches it either. **The vote is the next step, and it is a different mail.** Once the test build is announced, `creating-release-vote-mail` composes the `[VOTE] Apache Struts X.Y.Z` call — to `dev@` alone, rendered from the page this skill produced. Do not draft it from here: its recipients, subject and body all differ from the announcement above. diff --git a/.claude/skills/creating-version-notes/version-notes-template.md b/.claude/skills/creating-version-notes/version-notes-template.md index 1961df03e2..475af93b6d 100644 --- a/.claude/skills/creating-version-notes/version-notes-template.md +++ b/.claude/skills/creating-version-notes/version-notes-template.md @@ -150,3 +150,4 @@ Repeat the issue `

` block per type present, in the order given above. - [ ] Addressed to **both** `dev@struts.apache.org` and `user@struts.apache.org`, Bcc `private@struts.apache.org`. - [ ] Risk clause matches reality: silent when there are no Breaking changes, "but it contains significant changes" when there are. - [ ] Tag underscored in the release link, version dotted in the dist path and page title. +- [ ] Hand-over says to switch the From to `lukaszlenart@apache.org` — the draft tool cannot set it. From e1a845f9d63b3cfe7b14e99cb1cfcc49f522f52c Mon Sep 17 00:00:00 2001 From: Lukasz Lenart Date: Fri, 18 Sep 2026 06:47:21 +0200 Subject: [PATCH 2/2] docs(skills): name the @apache.org identity, not one committer's address The skill is shared; the rule is that the announcement goes out from the release manager's @apache.org address, whoever that is. Co-Authored-By: Claude Opus 5 (1M context) --- .claude/skills/creating-version-notes/SKILL.md | 11 ++++++----- .../creating-version-notes/version-notes-template.md | 2 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.claude/skills/creating-version-notes/SKILL.md b/.claude/skills/creating-version-notes/SKILL.md index 26fba47380..c94a5ad779 100644 --- a/.claude/skills/creating-version-notes/SKILL.md +++ b/.claude/skills/creating-version-notes/SKILL.md @@ -272,11 +272,12 @@ Kind regards Do not take the recipients from a previous announcement: 6.11.0 went to `dev@` alone and 7.3.0 to `user@` alone, and both were mistakes. Address every announcement to the two lists above. -**It is sent from `lukaszlenart@apache.org`, and the draft cannot say so.** The Gmail draft tool has no -sender field, so every draft it creates carries the account's personal default address. When handing -the draft over, say in the same sentence that the From must be switched to the `@apache.org` identity -before sending — a test build announced from a personal address reads as an outsider's mail in the -list archive, and `creating-release-vote-mail` needs the same switch for the `[VOTE]`. +**It is sent from the release manager's `@apache.org` address, and the draft cannot say so.** The +Gmail draft tool has no sender field, so every draft it creates carries the account's default address, +which may be a personal one. When handing the draft over, say in the same sentence that the From must be +switched to the `@apache.org` identity before sending — a test build announced from a personal address +reads as an outsider's mail in the list archive, and `creating-release-vote-mail` needs the same switch +for the `[VOTE]`. Keep the security posture of the pages: the mail links the release notes, it does not summarise what is in them, so no severity, CVE or S2-XXX reaches it either. diff --git a/.claude/skills/creating-version-notes/version-notes-template.md b/.claude/skills/creating-version-notes/version-notes-template.md index 475af93b6d..9c58c2c1f5 100644 --- a/.claude/skills/creating-version-notes/version-notes-template.md +++ b/.claude/skills/creating-version-notes/version-notes-template.md @@ -150,4 +150,4 @@ Repeat the issue `

` block per type present, in the order given above. - [ ] Addressed to **both** `dev@struts.apache.org` and `user@struts.apache.org`, Bcc `private@struts.apache.org`. - [ ] Risk clause matches reality: silent when there are no Breaking changes, "but it contains significant changes" when there are. - [ ] Tag underscored in the release link, version dotted in the dist path and page title. -- [ ] Hand-over says to switch the From to `lukaszlenart@apache.org` — the draft tool cannot set it. +- [ ] Hand-over says to switch the From to the release manager's `@apache.org` address — the draft tool cannot set it.