From c5eae15f0317c432f616b862029bd42684ec3a8d Mon Sep 17 00:00:00 2001
From: slfan1989 <slfan1989@apache.org>
Date: Thu, 5 Nov 2026 13:25:05 +0800
Subject: [PATCH] fix(datafusion): reject UPDATE and DELETE on temporary
 targets

---
 .../datafusion/src/sql_context.rs             | 10 ++++
 .../datafusion/tests/sql_context_tests.rs     | 48 +++++++++++++++++++
 2 files changed, 58 insertions(+)

diff --git a/crates/integrations/datafusion/src/sql_context.rs b/crates/integrations/datafusion/src/sql_context.rs
index 99b92af7c..88d450047 100644
--- a/crates/integrations/datafusion/src/sql_context.rs
+++ b/crates/integrations/datafusion/src/sql_context.rs
@@ -1881,6 +1881,11 @@ impl SQLContext {
             }
         };
         Self::ensure_main_branch_write_target(&table_name, "UPDATE")?;
+        if self.temp_table_for(&table_name).await?.is_some() {
+            return Err(DataFusionError::NotImplemented(
+                "UPDATE on temporary tables or views is not supported".into(),
+            ));
+        }
         let (catalog, _catalog_name, identifier) = self.resolve_catalog_and_table(&table_name)?;
 
         let table = catalog
@@ -1909,6 +1914,11 @@ impl SQLContext {
             }
         };
         Self::ensure_main_branch_write_target(&table_name, "DELETE")?;
+        if self.temp_table_for(&table_name).await?.is_some() {
+            return Err(DataFusionError::NotImplemented(
+                "DELETE on temporary tables or views is not supported".into(),
+            ));
+        }
         let (catalog, _catalog_name, identifier) = self.resolve_catalog_and_table(&table_name)?;
 
         let table = catalog
diff --git a/crates/integrations/datafusion/tests/sql_context_tests.rs b/crates/integrations/datafusion/tests/sql_context_tests.rs
index 8ff8fed67..f5ac4fe15 100644
--- a/crates/integrations/datafusion/tests/sql_context_tests.rs
+++ b/crates/integrations/datafusion/tests/sql_context_tests.rs
@@ -1028,6 +1028,54 @@ async fn test_scoped_show_accepts_temp_only_database_and_shadowing() {
     );
 }
 
+#[tokio::test]
+async fn test_update_and_delete_reject_shadowed_temporary_targets() {
+    let (_tmp, catalog) = create_test_env();
+    let ctx = create_sql_context(catalog).await;
+    ctx.sql("CREATE TABLE default.shadowed (id INT)")
+        .await
+        .unwrap();
+    ctx.sql("INSERT INTO default.shadowed VALUES (1), (2)")
+        .await
+        .unwrap()
+        .collect()
+        .await
+        .unwrap();
+
+    for kind in ["TABLE", "VIEW"] {
+        ctx.sql(&format!(
+            "CREATE TEMPORARY {kind} default.shadowed AS SELECT CAST(999 AS INT) AS id"
+        ))
+        .await
+        .unwrap();
+        assert_eq!(
+            collect_ids(&ctx, "SELECT id FROM shadowed").await,
+            vec![999]
+        );
+
+        assert_sql_error_contains(
+            &ctx,
+            "UPDATE shadowed SET id = 10 WHERE id = 1",
+            "UPDATE on temporary tables or views is not supported",
+        )
+        .await;
+        assert_sql_error_contains(
+            &ctx,
+            "DELETE FROM paimon.default.shadowed WHERE id = 2",
+            "DELETE on temporary tables or views is not supported",
+        )
+        .await;
+
+        ctx.sql(&format!("DROP TEMPORARY {kind} default.shadowed"))
+            .await
+            .unwrap();
+        assert_eq!(
+            collect_ids(&ctx, "SELECT id FROM shadowed ORDER BY id").await,
+            vec![1, 2]
+        );
+    }
+}
+
 #[tokio::test]
 async fn test_scoped_show_accepts_information_schema() {
     let (_tmp, catalog) = create_test_env();