From dce5ce9fb73b8eb83ce07c7c41fd824019357a9e Mon Sep 17 00:00:00 2001 From: Master0fFate <119829254+Master0fFate@users.noreply.github.com> Date: Sun, 22 Nov 2026 10:06:36 +0100 Subject: [PATCH 1/2] Open Run on Agents and keep tool history in Activity --- DESIGN.md | 2 +- src/renderer/app/App.test.tsx | 2 +- .../features/chat/ConversationTimeline.tsx | 7 +++- src/renderer/features/chat/ToolCard.tsx | 4 +- src/renderer/features/shell/Inspector.tsx | 42 +++++-------------- .../shell/SubagentSessionsPanel.test.tsx | 7 ++-- src/renderer/skins/InspectorTabs.test.tsx | 16 +++---- src/renderer/skins/surfaces.ts | 2 +- src/renderer/stores/uiStore.test.ts | 8 ++-- src/renderer/stores/uiStore.ts | 21 +++++----- src/renderer/styles/global.css | 8 ---- tests/e2e/angelcore-complete.spec.ts | 1 - tests/e2e/inspector-navigation.spec.ts | 10 ++--- tests/e2e/m3-expressive.spec.ts | 4 +- tests/e2e/m3-inspector-tabs.spec.ts | 9 ++-- 15 files changed, 57 insertions(+), 86 deletions(-) diff --git a/DESIGN.md b/DESIGN.md index 4cdefdcd..87f36400 100644 --- a/DESIGN.md +++ b/DESIGN.md @@ -98,7 +98,7 @@ Native-feeling UI sans handles controls, navigation, and conversation. The platf ## Layout -The default desktop is a resizable three-column workbench: sessions/resources at left, a fluid conversation center, and Changes/Files/Tools/Context at right. The left pane collapses to a 64px rail; the inspector collapses fully. The manual terminal occupies a bounded lower panel. Panel sizes persist locally, while viewport-relative caps protect the center at narrower widths. +The default desktop is a resizable three-column workbench: sessions/resources at left, a fluid conversation center, and a Work/Run/System inspector at right. Run opens on Agents by default, followed by Goal, Monitor, and Activity. Tool events appear in Activity. The left pane collapses to a 64px rail; the inspector collapses fully. The manual terminal occupies a bounded lower panel. Panel sizes persist locally, while viewport-relative caps protect the center at narrower widths. Virtualized lists own their scroll regions. Streaming content grows inside the timeline and never changes the outer grid. diff --git a/src/renderer/app/App.test.tsx b/src/renderer/app/App.test.tsx index 73f39bd9..f69326c9 100644 --- a/src/renderer/app/App.test.tsx +++ b/src/renderer/app/App.test.tsx @@ -60,7 +60,7 @@ describe('first-launch shell', () => { delete document.documentElement.dataset.holyShitMode; useUiStore.setState({ sidebarCollapsed: false, sidebarTab: 'sessions', inspectorCollapsed: false, leftWidth: 264, rightWidth: 332, - inspectorTab: 'changes', inspectorLastViews: { work: 'changes', run: 'goal', system: 'context' }, selectedAgent: null, + inspectorTab: 'changes', inspectorLastViews: { work: 'changes', run: 'sessions', system: 'context' }, selectedAgent: null, terminalOpen: false, browserOpen: false, musicPlayerEnabled: false, musicPlaying: false, sendMessageWithModifier: false, paletteOpen: false, settingsOpen: false, toast: null, composerDraftRequest: null, goalEditorOpen: false, }); diff --git a/src/renderer/features/chat/ConversationTimeline.tsx b/src/renderer/features/chat/ConversationTimeline.tsx index 09ddbd04..ebb9ec82 100644 --- a/src/renderer/features/chat/ConversationTimeline.tsx +++ b/src/renderer/features/chat/ConversationTimeline.tsx @@ -408,13 +408,16 @@ const DesktopConversationTimeline = memo(function DesktopConversationTimeline({ if (!flightDeckJump || flightDeckJump.projectPath !== projectPath || flightDeckJump.sessionId !== sessionId) return; const targetId = flightDeckJump.target.kind === 'message' ? flightDeckJump.target.timelineId ?? `message:${flightDeckJump.target.messageId}` - : flightDeckJump.target.kind === 'error' ? flightDeckJump.target.timelineId : null; + : flightDeckJump.target.kind === 'tool' ? `tool:${flightDeckJump.target.toolCallId}` + : flightDeckJump.target.kind === 'error' ? flightDeckJump.target.timelineId : null; if (!targetId) return; const index = displayOrder.indexOf(targetId); if (index >= 0) { virtuosoRef.current?.scrollToIndex({ index, align: 'center', behavior: 'auto' }); + if (flightDeckJump.target.kind === 'tool') return; } else { - showToast({ kind: 'info', title: 'Activity not retained', message: 'That conversation activity is no longer kept.' }); + showToast({ kind: 'info', title: 'Activity not retained', message: flightDeckJump.target.kind === 'tool' + ? 'That tool execution is not shown in the conversation.' : 'That conversation activity is no longer kept.' }); } clearFlightDeckJump(flightDeckJump.nonce); }, [clearFlightDeckJump, displayOrder, flightDeckJump, projectPath, sessionId, showToast]); diff --git a/src/renderer/features/chat/ToolCard.tsx b/src/renderer/features/chat/ToolCard.tsx index 04a137f1..f5fee332 100644 --- a/src/renderer/features/chat/ToolCard.tsx +++ b/src/renderer/features/chat/ToolCard.tsx @@ -34,7 +34,7 @@ function presentedWorkflowToolStatus(toolStatus: RuntimeTool['status'], workflow return toolStatus; } -export const ToolCard = memo(function ToolCard({ toolCallId, compact = false, waitPollCount = 1, expansionCommand }: { toolCallId: string; compact?: boolean; waitPollCount?: number | undefined; expansionCommand?: DetailExpansionCommand }) { +export const ToolCard = memo(function ToolCard({ toolCallId, waitPollCount = 1, expansionCommand }: { toolCallId: string; waitPollCount?: number | undefined; expansionCommand?: DetailExpansionCommand }) { const { Symbol } = useSkinComponents(); const tool = useRuntimeStore((state) => state.toolsById[toolCallId]); const childStatusKey = useRuntimeStore((state) => state.toolsById[toolCallId]?.subagentRunIds @@ -75,7 +75,7 @@ export const ToolCard = memo(function ToolCard({ toolCallId, compact = false, wa const images = showImages && loadedImages?.length ? loadedImages : null; return ( -
+