From bec4966f96196ae67c09f7c3e3e116ab171fb3c7 Mon Sep 17 00:00:00 2001 From: mrafeie Date: Tue, 15 Sep 2026 17:16:58 +0100 Subject: [PATCH 1/6] Fix countChar function to correctly count characters --- Sprint-3/2-practice-tdd/count.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Sprint-3/2-practice-tdd/count.js b/Sprint-3/2-practice-tdd/count.js index 95b6ebb7d4..79977793e5 100644 --- a/Sprint-3/2-practice-tdd/count.js +++ b/Sprint-3/2-practice-tdd/count.js @@ -1,5 +1,13 @@ function countChar(stringOfCharacters, findCharacter) { - return 5 + let count = 0; + + for (let i = 0; i < stringOfCharacters.length; i++) { + if (stringOfCharacters[i] === findCharacter) { + count++; + } + } + + return count; } module.exports = countChar; From 04675776b1092126b09f23d7b3d023cbcbf4cf46 Mon Sep 17 00:00:00 2001 From: mrafeie Date: Tue, 15 Sep 2026 17:17:36 +0100 Subject: [PATCH 2/6] Add test for character not existing in string --- Sprint-3/2-practice-tdd/count.test.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Sprint-3/2-practice-tdd/count.test.js b/Sprint-3/2-practice-tdd/count.test.js index 179ea0ddf7..3fd6836489 100644 --- a/Sprint-3/2-practice-tdd/count.test.js +++ b/Sprint-3/2-practice-tdd/count.test.js @@ -22,3 +22,12 @@ test("should count multiple occurrences of a character", () => { // And a character `char` that does not exist within `str`. // When the function is called with these inputs, // Then it should return 0, indicating that no occurrences of `char` were found. + +test("should return 0 when character does not exist in the string", () => { + const str = "hello world"; + const char = "x"; + const count = countChar(str, char); + expect(count).toEqual(0); +}); + +//bug found, improved the function. test passed. From e62df9f134f4bb5679b588df6979375452c421fb Mon Sep 17 00:00:00 2001 From: mrafeie Date: Tue, 15 Sep 2026 17:19:11 +0100 Subject: [PATCH 3/6] Implement getOrdinalNumber function for ordinal suffixes --- Sprint-3/2-practice-tdd/get-ordinal-number.js | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/Sprint-3/2-practice-tdd/get-ordinal-number.js b/Sprint-3/2-practice-tdd/get-ordinal-number.js index f95d71db13..a00fd42851 100644 --- a/Sprint-3/2-practice-tdd/get-ordinal-number.js +++ b/Sprint-3/2-practice-tdd/get-ordinal-number.js @@ -1,5 +1,19 @@ function getOrdinalNumber(num) { - return "1st"; + + const lastDigit = num % 10; + const lastTwoDigits = num % 100; + if (lastTwoDigits === 11 || lastTwoDigits === 12 || lastTwoDigits === 13) { + return num + "th"; + } + if (lastDigit === 1) { + return num + "st"; + } else if (lastDigit === 2) { + return num + "nd"; + } else if (lastDigit === 3) { + return num + "rd"; + } else { + return num + "th"; + } } module.exports = getOrdinalNumber; From 9dc1f24f662a573d1e50d264ee54414f0b761f3b Mon Sep 17 00:00:00 2001 From: mrafeie Date: Tue, 15 Sep 2026 17:19:48 +0100 Subject: [PATCH 4/6] Add tests for ordinal number suffixes --- .../2-practice-tdd/get-ordinal-number.test.js | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/Sprint-3/2-practice-tdd/get-ordinal-number.test.js b/Sprint-3/2-practice-tdd/get-ordinal-number.test.js index adfa58560f..a9c6a52252 100644 --- a/Sprint-3/2-practice-tdd/get-ordinal-number.test.js +++ b/Sprint-3/2-practice-tdd/get-ordinal-number.test.js @@ -18,3 +18,24 @@ test("should append 'st' for numbers ending with 1, except those ending with 11" expect(getOrdinalNumber(21)).toEqual("21st"); expect(getOrdinalNumber(131)).toEqual("131st"); }); + +test("should append 'nd' for numbers ending with 2, except those ending with 12", () => { + expect(getOrdinalNumber(2)).toEqual("2nd"); + expect(getOrdinalNumber(42)).toEqual("42nd"); + expect(getOrdinalNumber(782)).toEqual("782nd"); +}); + +test("should append 'rd' for numbers ending with 3, except those ending with 13", () => { + expect(getOrdinalNumber(3)).toEqual("3rd"); + expect(getOrdinalNumber(93)).toEqual("93rd"); + expect(getOrdinalNumber(7253)).toEqual("7253rd"); +}); + +test("should append 'th' for numbers ending with numbers 0, 4-9 and numbers whose last two digits are 11, 12, or 13", () => { + expect(getOrdinalNumber(11)).toEqual("11th"); + expect(getOrdinalNumber(12)).toEqual("12th"); + expect(getOrdinalNumber(13)).toEqual("13th"); + expect(getOrdinalNumber(20)).toEqual("20th"); + expect(getOrdinalNumber(75)).toEqual("75th"); + expect(getOrdinalNumber(567)).toEqual("567th"); +}); From dfc96cdd11b1233f8aa132afb12b8dea8c5258a7 Mon Sep 17 00:00:00 2001 From: mrafeie Date: Tue, 15 Sep 2026 17:20:19 +0100 Subject: [PATCH 5/6] Implement repeatStr function with error handling Re-implemented repeatStr function to repeat a string a specified number of times without using String.prototype.repeat. Added error handling for negative counts. --- Sprint-3/2-practice-tdd/repeat-str.js | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/Sprint-3/2-practice-tdd/repeat-str.js b/Sprint-3/2-practice-tdd/repeat-str.js index 2af0a2cea7..48679b224e 100644 --- a/Sprint-3/2-practice-tdd/repeat-str.js +++ b/Sprint-3/2-practice-tdd/repeat-str.js @@ -1,7 +1,15 @@ -function repeatStr() { - // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). - // The goal is to re-implement that function, not to use it. - return "hellohellohello"; +function repeatStr(str, count) { + if (count < 0) { + throw new Error("Count cannot be negative"); + } + + let result = ""; + + for (let i = 0; i < count; i++) { + result += str; + } + + return result; } module.exports = repeatStr; From abdc8e7243df8690331f943e09915aaa6782674d Mon Sep 17 00:00:00 2001 From: mrafeie Date: Tue, 15 Sep 2026 17:21:16 +0100 Subject: [PATCH 6/6] Add tests for repeatStr function edge cases --- Sprint-3/2-practice-tdd/repeat-str.test.js | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/Sprint-3/2-practice-tdd/repeat-str.test.js b/Sprint-3/2-practice-tdd/repeat-str.test.js index a3fc1196c4..5512d6af4b 100644 --- a/Sprint-3/2-practice-tdd/repeat-str.test.js +++ b/Sprint-3/2-practice-tdd/repeat-str.test.js @@ -21,12 +21,27 @@ test("should repeat the string count times", () => { // When the repeatStr function is called with these inputs, // Then it should return the original `str` without repetition. +test("should return the original string when count is 1", () => { + expect(repeatStr("hello", 1)).toEqual("hello"); +}); + + // Case: Handle count of 0: // Given a target string `str` and a `count` equal to 0, // When the repeatStr function is called with these inputs, // Then it should return an empty string. +test("should return an empty string when count is 0", () => { + expect(repeatStr("hello", 0)).toEqual(""); +}); + + // Case: Handle negative count: // Given a target string `str` and a negative integer `count`, // When the repeatStr function is called with these inputs, // Then it should throw an error, as negative counts are not valid. + + +test("should throw an error when count is negative", () => { + expect(() => repeatStr("hello", -1)).toThrow("Count cannot be negative"); +});