diff --git a/.changeset/team-default-filter-values-mode.md b/.changeset/team-default-filter-values-mode.md new file mode 100644 index 000000000..803b2f91f --- /dev/null +++ b/.changeset/team-default-filter-values-mode.md @@ -0,0 +1,7 @@ +--- +'@hyperdx/common-utils': patch +'@hyperdx/api': patch +'@hyperdx/app': patch +--- + +feat: Add a team-wide default (All or Exact) for the search filters "Show All Values" setting diff --git a/.gitignore b/.gitignore index c77d80ee0..a37a5e9dc 100644 --- a/.gitignore +++ b/.gitignore @@ -111,3 +111,4 @@ packages/*/reports/ docs/superpowers/ .superpowers/ .playwright-mcp/ +.agents/ diff --git a/packages/api/src/models/team.ts b/packages/api/src/models/team.ts index 1954e0ac7..346567694 100644 --- a/packages/api/src/models/team.ts +++ b/packages/api/src/models/team.ts @@ -46,6 +46,7 @@ export default mongoose.model( fieldMetadataDisabled: Boolean, parallelizeWhenPossible: Boolean, filterKeysFetchLimit: Number, + filterValuesExactByDefault: Boolean, }, { timestamps: true, diff --git a/packages/app/src/components/DBSearchPageFilters.tsx b/packages/app/src/components/DBSearchPageFilters.tsx index e25a657b4..98aae2d97 100644 --- a/packages/app/src/components/DBSearchPageFilters.tsx +++ b/packages/app/src/components/DBSearchPageFilters.tsx @@ -53,6 +53,7 @@ import { IconSitemap, } from '@tabler/icons-react'; +import api from '@/api'; import { IS_CLICKHOUSE_BUILD } from '@/config'; import { useColumns, @@ -1220,10 +1221,14 @@ const DBSearchPageFiltersComponent = ({ 'hdx-shared-filters-expanded', true, ); - const [showAllValues, setShowAllValues] = useLocalStorage( + const { data: me } = api.useMe(); + // null = user hasn't chosen, so fall back to the team default + const [userShowAllValues, setShowAllValues] = useLocalStorage( 'hdx-show-all-filter-values', - true, + null, ); + const teamShowAllValues = !me?.team?.filterValuesExactByDefault; + const showAllValues = userShowAllValues ?? teamShowAllValues; const { size, startResize } = useResizable(16, 'left'); const { data: source } = useSource({ id: sourceId }); @@ -1809,6 +1814,9 @@ const DBSearchPageFiltersComponent = ({ }} showAllValues={showAllValues} onShowAllValuesChange={setShowAllValues} + teamShowAllValues={teamShowAllValues} + isShowAllValuesOverridden={userShowAllValues != null} + onResetShowAllValues={() => setShowAllValues(null)} /> {onCollapse && ( diff --git a/packages/app/src/components/DBSearchPageFilters/FilterSettingsPopover.tsx b/packages/app/src/components/DBSearchPageFilters/FilterSettingsPopover.tsx index b1a044de7..d0fe5c83e 100644 --- a/packages/app/src/components/DBSearchPageFilters/FilterSettingsPopover.tsx +++ b/packages/app/src/components/DBSearchPageFilters/FilterSettingsPopover.tsx @@ -41,6 +41,9 @@ export function FilterSettingsPanel({ onResetSharedFilters, showAllValues, onShowAllValuesChange, + teamShowAllValues, + isShowAllValuesOverridden, + onResetShowAllValues, }: { isSharedFiltersVisible: boolean; onSharedFiltersVisibilityChange: (visible: boolean) => void; @@ -52,6 +55,9 @@ export function FilterSettingsPanel({ onResetSharedFilters: VoidFunction; showAllValues: boolean; onShowAllValuesChange: (show: boolean) => void; + teamShowAllValues: boolean; + isShowAllValuesOverridden: boolean; + onResetShowAllValues: VoidFunction; }) { const showResetSection = hasPersonalPins || hasSharedPins; @@ -117,6 +123,18 @@ export function FilterSettingsPanel({ onChange={e => onShowAllValuesChange(e.currentTarget.checked)} /> + + + Team default: {teamShowAllValues ? 'All' : 'Exact'} + + {isShowAllValuesOverridden && ( + + + Use team default + + + )} + {showResetSection && ( <> diff --git a/packages/app/src/components/TeamSettings/TeamQueryConfigSection.tsx b/packages/app/src/components/TeamSettings/TeamQueryConfigSection.tsx index cef40fb67..80907a47d 100644 --- a/packages/app/src/components/TeamSettings/TeamQueryConfigSection.tsx +++ b/packages/app/src/components/TeamSettings/TeamQueryConfigSection.tsx @@ -328,6 +328,13 @@ export default function TeamQueryConfigSection() { displayValue={displayValueWithUnit('keys')} description={`Default is ${DEFAULT_FILTER_KEYS_FETCH_LIMIT}`} /> + (value ? 'Exact' : 'All')} + />