Skip to content

fix(security): update clickhouse-go/v2 to v2.51.0 - #3743

Merged
kodiakhq[bot] merged 2 commits into
ClickHouse:mainfrom
DrMagPie:brotli
Nov 20, 2026
Merged

kodiakhq[bot] merged 2 commits into
ClickHouse:mainfrom
DrMagPie:brotli

Conversation

@DrMagPie

Copy link
Copy Markdown
Contributor

Summary

Update clickhouse-go/v2 to v2.51.0 and brotli to v1.2.7 to address CVE-2026-111497 (GO-2026-6888)

References

@DrMagPie
DrMagPie requested a review from a team as a code owner November 20, 2026 10:56
@vercel

vercel Bot commented Nov 20, 2026

Copy link
Copy Markdown

@DrMagPie is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot

changeset-bot Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 73d6c0f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/otel-collector Patch
@hyperdx/api Patch
@hyperdx/app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added external needs-vouch Author needs a maintainer to vouch for them labels Nov 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi @DrMagPie, thanks for the pull request!

Before we review code from a first-time contributor, a maintainer vouches for them, and you're not on our list yet. There's nothing else to file and this PR stays open — a maintainer will look at it, usually within a day or two, and vouch for you right here if it's a genuine attempt at the problem.

To make that quick, check the PR description has:

  • The issue it addresses (ideally one labelled Accepting PR) and why the change is needed
  • Steps to reproduce the problem and verify the fix, starting from https://play.hyperdx.io or yarn app:dev:local connected to the demo server
  • Before/after screenshots if anything in the UI changed

More detail in our contributing guide.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR Review

✅ No issues found.

@github-actions

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This is a well-scoped, security-motivated Go dependency bump in packages/otel-collector (the migration tool). The remediation claim was verified from the pinned versions: github.com/andybalholm/brotli is pinned at v1.2.7 — at or above the GO-2026-6888 / CVE-2026-111497 fixed version — in both packages/otel-collector/go.mod and packages/otel-collector/go.sum (full h1: + /go.mod hash pair present), not merely declared. All other bumped transitive modules carry complete hash pairs in go.sum, and no hash was dropped for a still-required module.

One lower-confidence finding was raised and resolved during synthesis:

  • The go.yaml.in/yaml/v3 v3.0.5 entry was removed from the go.mod require block while go.sum retains its hashes. One reviewer flagged this as possibly non-tidy output, but a second reviewer independently established it is the expected result of Go 1.17+ module-graph pruning (a transitive dep drops from require while its build-graph hashes remain — the same pattern already present for modernc.org/*, stretchr/testify, and others in this file). It is below the confidence bar and refuted by cross-review, so it is not reported as an actionable finding.

Reviewers (5): correctness, security, maintainability, project-standards, previous-comments.

Testing gaps:

  • The Go toolchain could not be executed in this review environment, so go build ./..., go mod verify, and go mod tidy -diff were not run — confirm these pass in CI to positively rule out any build break from the transitive bumps (clickhouse-go 2.43→2.51, ch-go 0.71→0.75, klauspost/compress 1.18→1.20, paulmach/orb 0.12→0.14).
  • No vulnerability scanner was available offline — run govulncheck ./... in packages/otel-collector to confirm none of the newly pinned transitive deps introduce a fresh advisory.

@pulpdrew pulpdrew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@pulpdrew pulpdrew added automerge and removed needs-vouch Author needs a maintainer to vouch for them labels Nov 20, 2026
@kodiakhq
kodiakhq Bot merged commit d945d7e into ClickHouse:main Nov 20, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants