From 831d17447133c7ed6ed0c4148d00233c083ec8d5 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 25 Sep 2026 13:44:43 +0000 Subject: [PATCH 1/2] Initial plan From c0016beed3cb7391bfd3c72d3154372ad8dae769 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 25 Sep 2026 13:46:41 +0000 Subject: [PATCH 2/2] Fix cppcheck boolean operation warnings in eventSelectionQa Co-authored-by: altsybee <12641156+altsybee@users.noreply.github.com> --- DPG/Tasks/AOTEvent/eventSelectionQa.cxx | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/DPG/Tasks/AOTEvent/eventSelectionQa.cxx b/DPG/Tasks/AOTEvent/eventSelectionQa.cxx index c5da0ee0076..2bc561679d1 100644 --- a/DPG/Tasks/AOTEvent/eventSelectionQa.cxx +++ b/DPG/Tasks/AOTEvent/eventSelectionQa.cxx @@ -111,9 +111,9 @@ struct EventSelectionQaTask { ccdb->setCaching(true); ccdb->setLocalObjectValidityChecking(); - const AxisSpec axisMultV0M{1000, 0., isLowFlux ? 40000. : 40000., "V0M multiplicity"}; + const AxisSpec axisMultV0M{1000, 0., 40000., "V0M multiplicity"}; const AxisSpec axisMultV0A{1000, 0., isLowFlux ? 40000. : 200000., "V0A multiplicity"}; - const AxisSpec axisMultV0C{1000, 0., isLowFlux ? 30000. : 30000., "V0C multiplicity"}; + const AxisSpec axisMultV0C{1000, 0., 30000., "V0C multiplicity"}; const AxisSpec axisMultT0A{1000, 0., isLowFlux ? 10000. : 200000., "T0A multiplicity"}; const AxisSpec axisMultT0C{1000, 0., isLowFlux ? 2000. : 70000., "T0C multiplicity"}; const AxisSpec axisMultT0M{1000, 0., isLowFlux ? 12000. : 270000., "T0M multiplicity"}; @@ -568,9 +568,7 @@ struct EventSelectionQaTask { histos.fill(HIST("hV0C012vsTklCol"), nTracklets, multRingV0C012); // filling plots for accepted events - bool accepted = 0; - accepted |= !isINT1period & col.sel7(); - accepted |= isINT1period & sel1; + bool accepted = (!isINT1period && col.sel7()) || (isINT1period && sel1); if (!accepted) { continue; } @@ -786,13 +784,13 @@ struct EventSelectionQaTask { const auto& bcPast = bcs.iteratorAt(bc.globalIndex() - deltaIndex); deltaBC = globalBC - bcPast.globalBC(); if (deltaBC < maxDeltaBC) { - pastActivityFT0 |= bcPast.has_ft0(); - pastActivityFV0 |= bcPast.has_fv0a(); - pastActivityFDD |= bcPast.has_fdd(); + pastActivityFT0 = pastActivityFT0 || bcPast.has_ft0(); + pastActivityFV0 = pastActivityFV0 || bcPast.has_fv0a(); + pastActivityFDD = pastActivityFDD || bcPast.has_fdd(); } } - bool pastActivity = pastActivityFT0 | pastActivityFV0 | pastActivityFDD; + bool pastActivity = pastActivityFT0 || pastActivityFV0 || pastActivityFDD; int localBC = bc.globalBC() % nBCsPerOrbit; float timeV0A = bc.has_fv0a() ? bc.fv0a().time() : -999.f;